Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impedance settings in joints.py have mixed real and non-dim inputs #147

Open
tkevinbest opened this issue Oct 21, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@tkevinbest
Copy link
Member

🚀 Feature Request

The set_joint_impedance method and others require both the output impedance and the current control gains to be specified. The output impedance is in real units whereas the current control gains are in arbitrary dephy units. I think these commands should be separated to maintain the hardware abstraction functionality.

I think we should move setting any current control gains to its own method and if the user wants to change those, they need to call that method. Setting the joint impedance should be independent of the current control gains. Under the hood (because I know Flexsea requires us to send both impedance and current control gains together), we should keep track of the latest current control gains and just handle adding those in for the user.

@tkevinbest tkevinbest added the enhancement New feature or request label Oct 21, 2023
@imsenthur imsenthur self-assigned this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

2 participants