[ENH] Set up federation prototype and CI workflows #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set up route and crud function for basic federation request Still the same * Yay, federation! Co-authored-by: Alyssa Dai <alyssa.ydai@gmail.com> Co-authored-by: rmanaem <rmanaem@protonmail.ch>
* Changed router prefix and tag to `query` * Cleaned the good stuff Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com> Co-authored-by: Alyssa Dai <alyssa.ydai@gmail.com> * Updated docstring for `get` function of `crud.py` Co-authored-by: Alyssa Dai <alyssa.dai@mail.mcgill.ca> --------- Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com> Co-authored-by: Alyssa Dai <alyssa.ydai@gmail.com> Co-authored-by: Alyssa Dai <alyssa.dai@mail.mcgill.ca>
* Turned NEUROBAGEL_NODES to an env var * Added dependabot.yaml config file * Added codespell.yaml workflow file * Added lint.yaml workflow file * Added build_docker.yaml workflow file
alyssadai
changed the title
surchs
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
All looks good to me @alyssadai. One comment/question and then 🧑🍳
|
|
||
| # Automatically start uvicorn server on execution of main.py | ||
| if __name__ == "__main__": | ||
| uvicorn.run("app.main:app", port=8000, reload=True) |
There was a problem hiding this comment.
does reload get ignored in prod? or should we remove that here?
There was a problem hiding this comment.
It gets ignored because of the Dockerfile entrypoint! This is the same as what we have for the node APIs.
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging all changes from the feature branch
dev.Checklist
[ENH],[FIX],[REF],[TST],[CI],[MNT],[INF],[MODEL],[DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXXFor new features:
For bug fixes: