Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Set up test workflow #17

Merged
merged 4 commits into from
Nov 13, 2023
Merged

[CI] Set up test workflow #17

merged 4 commits into from
Nov 13, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Nov 13, 2023 •
edited by surchs
Loading

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

alyssadai
alyssadai approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One 🍒 , otherwise 🧑‍🍳 !

.github/workflows/test.yaml Outdated Show resolved Hide resolved
surchs
surchs approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with one 🍒 to look at

🧑‍🍳

.github/workflows/test.yaml Outdated Show resolved Hide resolved
@surchs
Copy link
Contributor

surchs commented Nov 13, 2023

ah, in case #19 is simple, mind taking a look at that too?

@rmanaem rmanaem merged commit 32a990b into main Nov 13, 2023
3 checks passed
@rmanaem rmanaem deleted the maint-15 branch November 13, 2023 22:39
@surchs
Copy link
Contributor

surchs commented Apr 11, 2024

🚀 PR was released in v0.1.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

@alyssadai alyssadai alyssadai approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have tests run in CI
3 participants
@rmanaem @surchs @alyssadai