Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking org/cluster name validity before re-fetching config #2543

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Jan 21, 2022

Closes #2540

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #2543 (7f9a173) into master (0837638) will decrease coverage by 0.01%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2543      +/-   ##
==========================================
- Coverage   74.89%   74.88%   -0.02%     
==========================================
  Files          65       65              
  Lines       11083    11093      +10     
  Branches     2153     2155       +2     
==========================================
+ Hits         8301     8307       +6     
- Misses       2472     2476       +4     
  Partials      310      310              
Impacted Files Coverage Δ
neuro-sdk/src/neuro_sdk/_config.py 89.63% <ø> (ø)
neuro-cli/src/neuro_cli/click_types.py 55.13% <60.00%> (+0.11%) ⬆️
neuro-cli/src/neuro_cli/config.py 54.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0837638...7f9a173. Read the comment docs.

@asvetlov asvetlov merged commit 6ea9cc2 into master Jan 25, 2022
@asvetlov asvetlov deleted the rs/fix-switch-cache branch January 25, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding cache update to switch-org and switch-cluster
2 participants