Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace --http option with --http-port #2501

Merged
merged 3 commits into from
Dec 28, 2021
Merged

Replace --http option with --http-port #2501

merged 3 commits into from
Dec 28, 2021

Conversation

asvetlov
Copy link
Contributor

Keep --http option as a hidden deprecated alternative, scheduled for removal later.

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #2501 (fdc1df7) into master (814030f) will decrease coverage by 0.28%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2501      +/-   ##
==========================================
- Coverage   85.32%   85.04%   -0.29%     
==========================================
  Files          71       71              
  Lines       11841    11846       +5     
  Branches     2295     2296       +1     
==========================================
- Hits        10103    10074      -29     
- Misses       1359     1395      +36     
+ Partials      379      377       -2     
Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/job.py 79.38% <36.36%> (-0.58%) ⬇️
neuro-cli/src/neuro_cli/asyncio_utils.py 68.87% <0.00%> (-8.61%) ⬇️
neuro-cli/src/neuro_cli/ael.py 52.14% <0.00%> (-3.10%) ⬇️
neuro-cli/src/neuro_cli/formatters/jobs.py 78.71% <0.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814030f...fdc1df7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant