List roles #2496
Merged
List roles #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2496 +/- ##
===========================================
- Coverage 85.33% 74.92% -10.42%
===========================================
Files 71 66 -5
Lines 11828 11073 -755
Branches 2293 2146 -147
===========================================
- Hits 10094 8296 -1798
- Misses 1356 2474 +1118
+ Partials 378 303 -75
Continue to review full report at Codecov.
|
asvetlov
reviewed
Dec 28, 2021
| @@ -102,6 +102,16 @@ async def get_shares( | |||
| ret.append(Share(item["user"], Permission(uri, action))) | |||
| return ret | |||
|
|
|||
| async def get_subroles( | |||
There was a problem hiding this comment.
Would you write a test for this method?
There was a problem hiding this comment.
Sorry, forgot about it. Done.
romasku
force-pushed
the
rs/list-roles
branch
from
ca0376d
to
c003511
Compare
asvetlov
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by https://github.com/neuro-inc/platform-auth/pull/692
Closes #2395