Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sharing of buckets #2414

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Fix sharing of buckets #2414

merged 2 commits into from
Nov 12, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Nov 11, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #2414 (3cf24ae) into master (666679f) will increase coverage by 11.41%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2414       +/-   ##
===========================================
+ Coverage   71.51%   82.93%   +11.41%     
===========================================
  Files          67       67               
  Lines       11744    11764       +20     
  Branches     1787     1789        +2     
===========================================
+ Hits         8399     9756     +1357     
+ Misses       3073     1651     -1422     
- Partials      272      357       +85     
Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/utils.py 88.55% <0.00%> (+2.79%) ⬆️
neuro-sdk/src/neuro_sdk/errors.py 100.00% <0.00%> (ø)
neuro-sdk/src/neuro_sdk/parsing_utils.py 96.85% <0.00%> (+1.04%) ⬆️
neuro-cli/src/neuro_cli/parse_utils.py 91.09% <0.00%> (+1.04%) ⬆️
neuro-sdk/src/neuro_sdk/config_factory.py 94.23% <0.00%> (+1.28%) ⬆️
neuro-sdk/src/neuro_sdk/storage.py 93.72% <0.00%> (+1.39%) ⬆️
neuro-cli/src/neuro_cli/formatters/disks.py 98.57% <0.00%> (+1.42%) ⬆️
neuro-sdk/src/neuro_sdk/url_utils.py 90.90% <0.00%> (+1.81%) ⬆️
neuro-cli/src/neuro_cli/stats.py 83.69% <0.00%> (+2.17%) ⬆️
neuro-sdk/src/neuro_sdk/client.py 100.00% <0.00%> (+2.17%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666679f...3cf24ae. Read the comment docs.

@asvetlov asvetlov merged commit c27cba4 into master Nov 12, 2021
@asvetlov asvetlov deleted the rs/fix-grant-for-blobs branch November 12, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants