Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise dedicated NotSupportedError for unsupported REST API calls #2407

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Nov 1, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #2407 (b554974) into master (666679f) will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2407      +/-   ##
==========================================
+ Coverage   71.51%   71.54%   +0.02%     
==========================================
  Files          67       67              
  Lines       11744    11757      +13     
  Branches     1787     1789       +2     
==========================================
+ Hits         8399     8411      +12     
- Misses       3073     3074       +1     
  Partials      272      272              
Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/main.py 63.14% <0.00%> (-0.58%) ⬇️
neuro-sdk/src/neuro_sdk/__init__.py 84.21% <ø> (ø)
neuro-sdk/src/neuro_sdk/admin.py 93.93% <100.00%> (+0.25%) ⬆️
neuro-sdk/src/neuro_sdk/errors.py 100.00% <100.00%> (ø)
neuro-cli/src/neuro_cli/file_logging.py 84.21% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666679f...b554974. Read the comment docs.

@asvetlov asvetlov merged commit eda7a08 into master Nov 1, 2021
@asvetlov asvetlov deleted the graceful-not-supported branch November 1, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant