Add additional fields to JobDescription #2204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by neuro-inc/platform-api#1630
As platform-monitoring uses SDK to fetch jobs and it needs
being_dropped
andlogs_removed
fields to be able to clean up dropped jobs, we have to add this fields to SDK. I do not completely like the idea to expose these fields to public API, but on another side, it is much better than to have to reimplement "jobs client" in each service.I use the term "dropped" instead of "deleted" because we already have
jobs_for_deletion
method inplatform-api
which means "jobs to be deleted from k8s".