Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional fields to JobDescription #2204

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Jul 9, 2021

Blocked by neuro-inc/platform-api#1630

As platform-monitoring uses SDK to fetch jobs and it needs being_dropped and logs_removed fields to be able to clean up dropped jobs, we have to add this fields to SDK. I do not completely like the idea to expose these fields to public API, but on another side, it is much better than to have to reimplement "jobs client" in each service.

I use the term "dropped" instead of "deleted" because we already have jobs_for_deletion method in platform-api which means "jobs to be deleted from k8s".

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #2204 (90904cc) into master (7c3f587) will decrease coverage by 0.13%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2204      +/-   ##
==========================================
- Coverage   84.89%   84.75%   -0.14%     
==========================================
  Files          65       65              
  Lines       10503    10515      +12     
  Branches     1640     1644       +4     
==========================================
- Hits         8916     8912       -4     
- Misses       1279     1290      +11     
- Partials      308      313       +5     
Flag Coverage Δ
cli 63.92% <ø> (ø)
e2e 61.68% <66.66%> (-0.11%) ⬇️
sdk 89.18% <66.66%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-sdk/src/neuro_sdk/jobs.py 91.98% <66.66%> (-0.52%) ⬇️
neuro-sdk/src/neuro_sdk/core.py 92.41% <0.00%> (-2.07%) ⬇️
neuro-cli/src/neuro_cli/ael.py 48.83% <0.00%> (-1.63%) ⬇️
neuro-cli/src/neuro_cli/asyncio_utils.py 79.37% <0.00%> (-0.63%) ⬇️
neuro-cli/src/neuro_cli/main.py 74.39% <0.00%> (-0.61%) ⬇️
neuro-cli/src/neuro_cli/formatters/jobs.py 80.10% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c3f587...90904cc. Read the comment docs.

@romasku romasku merged commit 2bb63ef into master Jul 12, 2021
@romasku romasku deleted the rs/additional-job-fields branch July 12, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants