Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] make sparsify.beta tests pass #220

Merged
merged 17 commits into from
Jun 14, 2023

Conversation

rahul-tuli
Copy link
Member

@rahul-tuli rahul-tuli commented Jun 7, 2023

This PR accomplishes the following:

  • Switches on tests for sparsify.beta in GHA workflow
  • Cherry picks changes from Add login step to test setup #216 to include login in sparsify.beta
  • fixes a renaming issue where some instances of the old function name were not updated
  • At some point the TaskName class was update to accept things like image classification (with a space in b/w) as a valid TaskName but the tests were not, this PR updates the tests accordingly
  • Updates version for sparsify.beta from diff [Cherry-Pick] Update version sparsify beta 1.6.0 #219
  • Install sparseml[yolov5] before running auto tests

PYDANTIC CLI REFACTOR

This branch also contains commits for the pydantic CLI refactor see PRs #209 and #221

@rahul-tuli rahul-tuli changed the title [bugfix] Propagate missed function renaming [bugfix] make sparsify.beta tests pass Jun 7, 2023
bfineran
bfineran previously approved these changes Jun 7, 2023
bfineran and others added 13 commits June 12, 2023 15:25
* fixes for initial E2E runs of sparse transfer and training aware

* quality
…er script (#208)

* Initial scratch work

* Complete, but untested implementation

* Working yolov5

* Working across all integrations

* IC path fix

* Require model

* Remove debug adds
* Update integration and unit tests

* Update IC base test model
Co-authored-by: dhuang <dhuang@MacBook-Pro-2.local>

(cherry picked from commit 699a476)

Co-authored-by: dhuangnm <74931910+dhuangnm@users.noreply.github.com>
@rahul-tuli rahul-tuli force-pushed the bugfix-propagate-refactored-changes branch from 66f19f0 to 58cc9eb Compare June 14, 2023 19:36
@rahul-tuli rahul-tuli changed the base branch from sparsify.beta to sparsify.beta.rebase June 14, 2023 19:36
* Add Model Args

* add some more models

* Add base function for converting pydantic models to click options

* intermediate commit

* Intermediate

* Add pydantic to click converter + reverter

* Add missing Params
Update function name as requested by @bfineran

* Update func name in tests
@bfineran bfineran changed the base branch from sparsify.beta.rebase to sparsify.beta June 14, 2023 20:12
bfineran and others added 2 commits June 14, 2023 16:13
* Add Model Args

* add some more models

* Add base function for converting pydantic models to click options

* intermediate commit

* Intermediate

* Add pydantic to click converter + reverter

* Add missing Params
Update function name as requested by @bfineran

* Update func name in tests

* Add Pydantic Models for various Args

* Add APIKey model

* Add new line

* Add new line

---------

Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
@bfineran
Copy link
Member

merging - @rahul-tuli to fix branch bugs after land

@bfineran bfineran merged commit 7824e74 into sparsify.beta Jun 14, 2023
1 of 2 checks passed
@bfineran bfineran deleted the bugfix-propagate-refactored-changes branch June 14, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants