-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] make sparsify.beta tests pass #220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rahul-tuli
changed the title
[bugfix] Propagate missed function renaming
[bugfix] make sparsify.beta tests pass
Jun 7, 2023
bfineran
previously approved these changes
Jun 7, 2023
* fixes for initial E2E runs of sparse transfer and training aware * quality
…er script (#208) * Initial scratch work * Complete, but untested implementation * Working yolov5 * Working across all integrations * IC path fix * Require model * Remove debug adds
* Update integration and unit tests * Update IC base test model
rahul-tuli
force-pushed
the
bugfix-propagate-refactored-changes
branch
from
June 14, 2023 19:36
66f19f0
to
58cc9eb
Compare
* Add Model Args * add some more models * Add base function for converting pydantic models to click options * intermediate commit * Intermediate * Add pydantic to click converter + reverter * Add missing Params Update function name as requested by @bfineran * Update func name in tests
* Add Model Args * add some more models * Add base function for converting pydantic models to click options * intermediate commit * Intermediate * Add pydantic to click converter + reverter * Add missing Params Update function name as requested by @bfineran * Update func name in tests * Add Pydantic Models for various Args * Add APIKey model * Add new line * Add new line --------- Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
merging - @rahul-tuli to fix branch bugs after land |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes the following:
image classification
(with a space in b/w) as a valid TaskName but the tests were not, this PR updates the tests accordinglyPYDANTIC CLI REFACTOR
This branch also contains commits for the pydantic CLI refactor see PRs #209 and #221