-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sparsify.init
CLI to create an project/experiment
#192
Conversation
71fd8e8
to
2561abd
Compare
sparsify.init
CLI to create an project/experimentsparsify.init
CLI to create an project/experiment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! Left some comments on the CLI
* Add a hidden debug option
* [Add] Create model_id * [Add] Create experiment * [Add] Create Project * [Move] Healthcheck logging to the respective function * [Add] Create analysis
* * Add SparsifyCredentials class to manage sparsify credentials and access/id tokens * Update sparsify.login and sparsify.init to use this class * Add Tests for sdparsify.login * Add Tests for SparsifyCredentials * Add Sparsify Client Add SparsifySession Add decorator for debug logging
8f9b888
to
2edb681
Compare
Check for existence before creating new projects/experiments/models Check if experiment initialization pending before running through
Extract core init functionality to an importable function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work - please review comments and let me know if you have any questions
* Move Client related code to a separate file `client.py` * Move Credentials creation to SparsifyClient * Add native support to read api-key from environment variable * Create requested helper methods * Update debug logs to use string formatting * create properties for access token and user info Add doctest(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
This PR represents the base feature branch for
sparsify.init
cli push