Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numpy 1.21.6 #332

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Update numpy 1.21.6 #332

merged 1 commit into from
Jun 26, 2023

Conversation

rahul-tuli
Copy link
Member

@rahul-tuli rahul-tuli commented Jun 12, 2023

Updates support to latest numpy
Needed to support deepsparse numpy version upgrade from neuralmagic/deepsparse#1094

The deepsparse change was made to support a ragged sequence being created in question answering pipeline during spans_extra_info computation; landing this diff along with neuralmagic/sparseml#1623 also fixes a few google colab errors we were seeing before.

@rahul-tuli rahul-tuli marked this pull request as ready for review June 26, 2023 18:51
@rahul-tuli rahul-tuli self-assigned this Jun 26, 2023
@rahul-tuli rahul-tuli added the enhancement New feature or request label Jun 26, 2023
@bfineran bfineran changed the title Update numpy Update numpy 1.21.6 Jun 26, 2023
@bfineran bfineran merged commit f6f4da2 into main Jun 26, 2023
4 checks passed
@bfineran bfineran deleted the upgrade-numpy branch June 26, 2023 20:39
@mgoin mgoin linked an issue Jun 27, 2023 that may be closed by this pull request
@SmartAudioTools
Copy link

Hello!
I'm still not able to install deepsparse with numpy>=1.22 with pip install.
The pipy version does not seem to include the modification

ERROR: Cannot install deepsparse and numpy>=1.22 because these package versions have conflicting dependencies.

The conflict is caused by:
The user requested numpy>=1.22
deepsparse 1.5.2 depends on numpy>=1.16.3
onnx 1.12.0 depends on numpy>=1.16.6
sparsezoo 1.5.2 depends on numpy<=1.21.6 and >=1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deepsparse support for numpy > 1.21.6 ?
3 participants