By default avoiding generating files in temp directory #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added the
conftests
so that after running any test target, the total size of files created after running the test suite can be: zero mb for the root directory, and up to 1mb for the temp directory.Audited the most important paths for
/src
and/tests
Audit Plan
Auditing the pathways that contain keywords:
tempfile
anddownload
to make sure that we are not being sloppy with saving or downloading files to the temporary directory.Auditing the
/src
Auditing the
/tests
Note: I consider saving to tempfile benign if it is either done within a
context
(using a context manager), or using thetmp_path
fixture or factory within thepytest
framework.