Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yolov5 docs update #684

Merged
merged 14 commits into from
Apr 8, 2022
Merged

Yolov5 docs update #684

merged 14 commits into from
Apr 8, 2022

Conversation

KSGulin
Copy link
Contributor

@KSGulin KSGulin commented Apr 7, 2022

Documentation update in support of Yolov5 update to V6.1 (neuralmagic/yolov5#26)

bfineran
bfineran previously approved these changes Apr 7, 2022
Copy link
Contributor

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @KSGulin will need to update any recipes/model cards in zoomodels as well

@bfineran bfineran requested review from markurtz, a team, mgoin and dbogunowicz and removed request for a team April 7, 2022 17:30
dbogunowicz
dbogunowicz previously approved these changes Apr 8, 2022
Copy link
Contributor

@dbogunowicz dbogunowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for now, I will also test those docs soon by following the instruction step-by-step.

@dbogunowicz dbogunowicz added the 0.12 release Pull request pending for 0.12 release. label Apr 8, 2022
@KSGulin KSGulin dismissed stale reviews from dbogunowicz and bfineran via 8374837 April 8, 2022 11:22
@KSGulin
Copy link
Contributor Author

KSGulin commented Apr 8, 2022

@anmarques Good catch Alex. Updated corresponding PRs to use the legacy hyperparameter files

dbogunowicz
dbogunowicz previously approved these changes Apr 8, 2022
Copy link
Contributor

@dbogunowicz dbogunowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed in private conversation with @KSGulin , I did run some rudimentary testing on the yolov5 and it works as expected (the base functionalities).

bfineran
bfineran previously approved these changes Apr 8, 2022
@spacemanidol spacemanidol merged commit 054bb61 into main Apr 8, 2022
@spacemanidol spacemanidol deleted the yolov5-docs-update branch April 8, 2022 18:58
dbogunowicz pushed a commit that referenced this pull request Apr 11, 2022
* Initial: yolov5 docs update for v6.1

* Update: move sparseml install outside requirements.txt

* Update: reference legacy hyperparam files

* Fix: nit

* Fix: remove redundant sparseml install

* point setup to release branch

Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
Co-authored-by: spacemanidol <dcampos3@illinois.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.12 release Pull request pending for 0.12 release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants