Preserve sparsity GPTQ #2281
Merged
Preserve sparsity GPTQ #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
requested review from
Satrat,
bfineran,
dsikka,
horheynm,
dbogunowicz and
abhinavnmagic
rahul-tuli
force-pushed
the
preserve-sparsity-gptq
branch
from
c220ab9
to
77ad1a2
Compare
bfineran
approved these changes
May 13, 2024
Satrat
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently a bug was revealed, where if GPTQ modifier was applied consecutively after SparseGPT, the weight sparsity mask was not being respected, this PR fixes that by preserving the mask, we do this automatically if the weight sparsity is greater than
SPARSITY_THRESHOLDwhich has been set to5%for now.Credits to @Satrat and @abhinavnmagic for proposing the fix
The unit test for consecutive application now runs w/o having to increase the relative tolerance which was done as a part of #2272