Split Wanda and SparseGPT
#2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sparsegpt not inherit from wanda modifier Decouple SparseGPTModifierPyTorch from WandaPruningModifier Fix docstrings
rahul-tuli
force-pushed
the
split-wanda-and-sparsegpt
branch
from
9e45a18
to
b1271ed
Compare
7 tasks
rahul-tuli
requested review from
Satrat,
bfineran,
dsikka,
horheynm and
dbogunowicz
bfineran
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
SparseGPTmodifier(s) to remove their inheritance fromWanda, makingSparseGPTfully independent. The change improves the modularity of the SparseGPT architecture, making it more straightforward to maintain and extend/modifyTest plan: Ran all the tests, + a manual one shot script on
HuggingFaceM4/tiny-random-LlamaForCausalLM