Allow torch 2.3 and remove torch ceiling version restriction #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
previously approved these changes
Apr 30, 2024
dbogunowicz
previously approved these changes
May 2, 2024
|
@bfineran @robertgshaw2-neuralmagic is this good with you going forward to not restrict pytorch? |
bfineran
previously approved these changes
May 6, 2024
8 tasks
|
@mgoin should we land this (after the GHA tests have passed?) |
mgoin
dismissed stale reviews from dbogunowicz, rahul-tuli, and bfineran
via
1d6091e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vLLM now requires torch 2.3.0, so we should try to raise the restriction in SparseML. Going forward, I think we shouldn't be so restrictive to newer versions of pytorch and should raise a warning at most, not an explicit exception.