Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip tests that do not work on CentOS 7 #1951

Closed
wants to merge 1 commit into from
Closed

Skip tests that do not work on CentOS 7 #1951

wants to merge 1 commit into from

Conversation

dbarbuzzi
Copy link
Contributor

This PR adds a conditional skip to a few tests that do not work on CentOS 7 due to external dependencies.

@dbarbuzzi dbarbuzzi self-assigned this Jan 11, 2024
@dbarbuzzi
Copy link
Contributor Author

It looks like the test-setup check was broken with #1858 - the run command starting on line 60 of https://github.com/neuralmagic/sparseml/pull/1858/files#diff-b105740d4a5ab1ea47925dd77d65be298e61913a5885693220e322871ba8bd4e has imbalanced parentheses (two open, one close); it’s also two-line shorter than equivalent checks which are using the same "template", so perhaps those lines are missing from that block.

bfineran
bfineran approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, didn't know about this feature in param

@dbarbuzzi
Copy link
Contributor Author

Closing this as a solution was found to update the host environment.

@dbarbuzzi dbarbuzzi closed this Jan 19, 2024
@dbarbuzzi dbarbuzzi deleted the skip-tests-on-centos7 branch January 19, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

Assignees

@dbarbuzzi dbarbuzzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbarbuzzi @bfineran