Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Export Refactor] Prepare the module to be more general (before including
transformers
) #1908[Export Refactor] Prepare the module to be more general (before including
transformers
) #1908Changes from 5 commits
23e892f
2bb1f20
fb20ae2
eab9fb1
0897615
9c7fac5
05a9ee3
450b286
313ecf8
6829514
4ada09a
5840eb5
d7c2375
c308949
ad2a7f0
9fbead1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of
apply_optimizations
top level function overhelper_functions.graph_optimizations
again worried about specificity to onnxThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
graph_optimization
contains a mapping that specifies all the possible optimizations for a specific integration. theapply_optimization
is a general function that establishes which of those optimizations should be actually applied and applies them. Why worried about onnx specificity? We could always pass thedeployment_target
as an argument ofapply_optimizations
- this actually demonstrates the usefulness of this abstraction.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still fail to see how folding this function into each of the
IntegrationHelperFunctions
is beneficial. It would add to code duplication, and IMO worsen the readability for the user. I'd propose to leave it for now, it's a very small component, can be refactored easily if needed.