-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[One Shot] Specify recipe_args on CLI #1902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Satrat I've tried out this PR, and while the overwriting of recipe args works as expected, the saved recipe still has the variable argument, i.e. without specific values. This I think will break other flows (e.g. evaluation). Could you please check that from your side?
Good catch! Yes we definitely want the output to reflect the evaluated args, I'll look into it further tomorrow |
Just an update on this: I had hoped this would be a quick bug fix, but trying to fix this revealed the new modifier refactor doesn't handle evaluated args correctly during export, so its going to be a bit more involved to fix. I opened a ticket to track: https://app.asana.com/0/1203126676641557/1206186419092269/f and will leave this PR open until its resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Requested by research, adding a CLI parameter for passing recipe args
Example Usage
test_recipe.yaml
To run:
Update: The output
recipe.yaml
will now reflect the evaluated argument value. Also added this recipe_arg feature to the finetuning script