-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Stacking Recipes #1897
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
approved these changes
Dec 18, 2023
rahul-tuli
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR towards alternating finetuning/one-shot support. Covers recipe and staging changes necessary to enable running recipes stage by stage between training and one-shot. Previously there was no way to differentiate between stages that had been previously applied and the active stage.
Summary of Changes
applied
attribute toStageModifiers
, used to differentiate which stages are initialized for structure only (already applied stages). If a stage has already been applied, we skip skip it during initialization and updatesapplied_stages
in theRecipeContainer
, so that when we reload the recipe after a stage is added we remember which have already been runQuantizationModifier
for determining if a module is already quantized. This allows us to stack quantization modifiers as long as they don't affect a common module. If attempting to quantize an already quantized module, we raise an exceptionTesting
Added new unit tests to
tests/sparseml/transformers/obcq/test_repeats.py