Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Export Refactor] Feature Branch #1858

Merged
merged 21 commits into from
Jan 10, 2024
Merged

[Export Refactor] Feature Branch #1858

merged 21 commits into from
Jan 10, 2024

Commits on Dec 29, 2023

  1. initial commit

    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    5058120 View commit details
    Browse the repository at this point in the history

  2. respond to PR comments

    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    bb5887e View commit details
    Browse the repository at this point in the history

  3. [Export Refactor][Image Classification] create_model function (#1878) 

    * initial commit

* looking good, time to cleanup

* Delete src/sparseml/export/helpers.py

* Delete tests/sparseml/export/test_helpers.py

* ready for review

* improve design

* tests pass

* reuse _validate_dataset_num_classes
    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    2930dea View commit details
    Browse the repository at this point in the history

  4. [Export Refactor][Image Classification] create_dummy_input function (… 

    …#1880)

* initial commit

* looking good, time to cleanup

* Delete src/sparseml/export/helpers.py

* Delete tests/sparseml/export/test_helpers.py

* ready for review

* improve design

* tests pass

* reuse _validate_dataset_num_classes

* initial commit

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* ready for review

* Update src/sparseml/export/export.py

* Update src/sparseml/integration_helper_functions.py
    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    5ac4d35 View commit details
    Browse the repository at this point in the history

  5. [Export Refactor][Image Classification] export_model function (#1883) 

    * initial commit

* looking good, time to cleanup

* Delete src/sparseml/export/helpers.py

* Delete tests/sparseml/export/test_helpers.py

* ready for review

* improve design

* tests pass

* reuse _validate_dataset_num_classes

* initial commit

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* ready for review

* Update src/sparseml/export/export.py

* Update src/sparseml/integration_helper_functions.py

* initial commit

* fixes

* ready for review

* nit

* add return

* make export function more general
    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    59f3f5a View commit details
    Browse the repository at this point in the history

  6. [Export Refactor][Image Classification] apply_optimizations function ( 

    #1884)

* initial commit

* looking good, time to cleanup

* Delete src/sparseml/export/helpers.py

* Delete tests/sparseml/export/test_helpers.py

* ready for review

* improve design

* tests pass

* reuse _validate_dataset_num_classes

* initial commit

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* ready for review

* Update src/sparseml/export/export.py

* Update src/sparseml/integration_helper_functions.py

* initial commit

* fixes

* ready for review

* nit

* add return

* initial commit
    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    9096b0d View commit details
    Browse the repository at this point in the history

  7. [Export Refactor][Image Classification] `export_sample_inputs_outputs… 

    …` function (#1888)

* initial commit

* looking good, time to cleanup

* Delete src/sparseml/export/helpers.py

* Delete tests/sparseml/export/test_helpers.py

* ready for review

* improve design

* tests pass

* reuse _validate_dataset_num_classes

* initial commit

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* ready for review

* Update src/sparseml/export/export.py

* Update src/sparseml/integration_helper_functions.py

* initial commit

* fixes

* ready for review

* nit

* add return

* initial commit

* initial commit

* PR comments

* beautification
    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    16c9bf3 View commit details
    Browse the repository at this point in the history

  8. remove duplicated function

    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    4d66402 View commit details
    Browse the repository at this point in the history

  9. [Export Refactor][Image Classification] create_deployment_folder fu… 

    …nction (#1889)

* initial commit

* looking good, time to cleanup

* Delete src/sparseml/export/helpers.py

* Delete tests/sparseml/export/test_helpers.py

* ready for review

* improve design

* tests pass

* reuse _validate_dataset_num_classes

* initial commit

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* ready for review

* Update src/sparseml/export/export.py

* Update src/sparseml/integration_helper_functions.py

* initial commit

* fixes

* ready for review

* nit

* add return

* initial commit

* initial commit

* initial commit

* fix rebase, tests_work

* ready to push
    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    ed04d3f View commit details
    Browse the repository at this point in the history

  10. [Export Refactor][Image Classification] validate_correctness functi… 

    …on (#1890)

* initial commit

* looking good, time to cleanup

* Delete src/sparseml/export/helpers.py

* Delete tests/sparseml/export/test_helpers.py

* ready for review

* improve design

* tests pass

* reuse _validate_dataset_num_classes

* initial commit

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* ready for review

* Update src/sparseml/export/export.py

* Update src/sparseml/integration_helper_functions.py

* initial commit

* fixes

* ready for review

* nit

* add return

* initial commit

* initial commit

* initial commit

* initial commit

* Delete tests/sparseml/test_integration_helper_functions.py

* ready to merge
    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    571aed8 View commit details
    Browse the repository at this point in the history

  11. [Export Refactor] End to end testing (#1898) 

    * initial commit

* looking good, time to cleanup

* Delete src/sparseml/export/helpers.py

* Delete tests/sparseml/export/test_helpers.py

* ready for review

* improve design

* tests pass

* reuse _validate_dataset_num_classes

* initial commit

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* ready for review

* Update src/sparseml/export/export.py

* Update src/sparseml/integration_helper_functions.py

* initial commit

* fixes

* ready for review

* nit

* add return

* initial commit

* initial commit

* initial commit

* initial commit

* Delete tests/sparseml/test_integration_helper_functions.py

* ready to merge

* add structure validator

* ready for review

* Delete tests/sparseml/export/model.onnx

* Delete tests/sparseml/export/image_classification/model.onnx

* Delete tests/sparseml/export/image_classification/conftest.py

* PR comments

* remove onnx
    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    627ddd6 View commit details
    Browse the repository at this point in the history

  12. [Export Refactor] Prepare the module to be more general (before inclu… 

    …ding `transformers`) (#1908)

* adapt the export script to handle transformers

* Update src/sparseml/pytorch/image_classification/integration_helper_functions.py

* Delete tests/sparseml/export/transformers/__init__.py

* Delete tests/sparseml/export/transformers/test_generative_transformers.py

* Delete tests/sparseml/export/transformers/test_transformers.py

* Update src/sparseml/export/export.py

Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>

* addressing review comments

* [Export Refactor] Export `transformers` (#1909)

* cleanup

* Delete src/sparseml/transformers/integration_helper_functions_generative.py

* Delete src/sparseml/transformers/utils/optimizations.py

* Delete tests/sparseml/export/transformers/test_generative_transformers.py

* Delete tests/sparseml/transformers/test_integration_helper_functions_generative.py

* addressing PR reviews

* [Export Refactor] Export generative transformers(#1910)

* make tests green, remove using task to resolve the integration type

* fix all the tests after the merge, make integration resolution independent of the task name

* fold generative transformers into transformer helper functions

* complete tests for export_data.py

* Update src/sparseml/export/export.py

* add tests that confirms that kv cache injection has been added

* move applying optimizations into integration helper functions

---------

Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
    @dbogunowicz @bfineran
    dbogunowicz and bfineran committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    3da5f23 View commit details
    Browse the repository at this point in the history

  13. [Export Refactor][Transformers] Enable loading SparseModels (#1921) 

    * initial commit

* adressing review comments
    @dbogunowicz
    dbogunowicz committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    c65ab6e View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Fix the tests

    @dbogunowicz
    dbogunowicz committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    e4770c8 View commit details
    Browse the repository at this point in the history

  2. fix tests with help from sara

    @dbogunowicz
    dbogunowicz committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    7b28881 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. [Export][Transformers] Enable loading text-generation datasets (#1938) 

    * add suport for past_key_values in sample-outputs

* [Export][Transformers] Implementation of correctness validation (#1935)

* fix tests with help from sara

* Update src/sparseml/transformers/utils/initializers.py

* swap sparsezoo validator for custom one (top k match)

* add more informative error message

* add correctness validation for LLMs

* remove past_key_values from outputs

* remove past_key_values from outputs (2)

* small note comment for the future
    @dbogunowicz
    dbogunowicz committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    6179cb2 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. tests fixed

    @dbogunowicz
    dbogunowicz committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    7f166a1 View commit details
    Browse the repository at this point in the history

  2. fix test

    @dbogunowicz
    dbogunowicz committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    c3c90a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. [Export refactor] final manual testing fixes (#1948) 

    * [Export refactor] final manual testing fixes

* review
    @bfineran
    bfineran committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    57a4dd0 View commit details
    Browse the repository at this point in the history

  2. Export Refactor CLI (#1949)

    @bfineran
    bfineran committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    ee78625 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/damian/feature_branch_export

    @bfineran
    bfineran committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    8c647b8 View commit details
    Browse the repository at this point in the history