Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Temp File Size Unit Test #1672

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fix Temp File Size Unit Test #1672

merged 2 commits into from
Jul 14, 2023

Conversation

Satrat
Copy link
Contributor

@Satrat Satrat commented Jul 13, 2023

  1. Adding tmp_path_retention_policy = "none" to pyproject.toml so that pytest deletes its temp files after every session, freeing up disk space.
  2. Because pytest takes care of deleting its own files, we can exclude them from the file size check in conftest.py

Testing

run make test TARGETS=transformers

Old Behavior

check_for_created_files() fails with error:

Failed: failed on teardown with "AssertionError: 2506.184633255005 megabytes of temp files created
 in temp directory during pytest run. 

New Behavior

tests pass without errors

Copy link
Contributor

@dbogunowicz dbogunowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbarbuzzi pinging you, so that you can rerun tests after this lands :)

@Satrat Satrat merged commit 162e6cc into main Jul 14, 2023
10 checks passed
@Satrat Satrat deleted the fix-temp-file-size-test branch July 14, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants