Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Py37 #1611

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Deprecate Py37 #1611

merged 2 commits into from
Jun 8, 2023

Conversation

rahul-tuli
Copy link
Member

Python 3.7 reaches it's EOL in ~2 weeks https://endoflife.date/python
This PR deprecated our support for the same

Remove `_nullcontext` as from 3.7+ there is a similar method in standard library
Copy link
Contributor

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the logic here just changing the Python version until the tests pass?

@rahul-tuli
Copy link
Member Author

Was the logic here just changing the Python version until the tests pass?

Yes!

Copy link
Contributor

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahul-tuli rahul-tuli merged commit ff98ca0 into main Jun 8, 2023
10 checks passed
@rahul-tuli rahul-tuli deleted the deprecate-py37 branch June 8, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants