Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for quantization modifier w/ DDP #1594

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Conversation

anmarques
Copy link
Member

Removes "module." from submodule names inserted by DDP.

Test plan:
Re-quantized the pruned 80% RN50 model with the following quantization modifier:

  - !QuantizationModifier
    start_epoch: eval(quant_start_epoch)
    disable_quantization_observer_epoch: eval(quant_disable_observer_epoch)
    freeze_bn_stats_epoch: eval(quant_freeze_bn_epoch)
    ignore: ['Softmax', 'classifier']

Before this PR the quantization modifier failed to match the "classifier" module name because under DDP this module was renamed as module.classifier

@anmarques anmarques requested a review from bfineran May 31, 2023 16:05
@anmarques anmarques merged commit 22e63cd into main Jun 6, 2023
@anmarques anmarques deleted the fix/quantization/module branch June 6, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants