Import the model.data from a single source variable in sparsezoo
#1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogunowicz
requested review from
rahul-tuli,
KSGulin,
dfneuralmagic and
a team
and removed request for
dfneuralmagic
KSGulin
approved these changes
Jun 5, 2023
bfineran
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid creating several source variables for file names (e.g
model.data), I think it is a good idea to define them once in Sparsezoo and import them from a common source.The GHA for this PR will probably be failing for a day or so, until this PR lands and gets included in the internal pypi nightly:
neuralmagic/sparsezoo#320