Skip onnx.check_model if model is too large #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoin
requested review from
a team,
rahul-tuli,
KSGulin and
robertgshaw2-neuralmagic
and removed request for
a team
bfineran
previously approved these changes
Apr 10, 2023
bfineran
approved these changes
Apr 10, 2023
dbogunowicz
approved these changes
Apr 11, 2023
| @@ -87,7 +87,14 @@ def validate_onnx_file(path: str): | |||
| """ | |||
| try: | |||
| onnx_model = check_load_model(path) | |||
| onnx.checker.check_model(onnx_model) | |||
|
|
|||
| if onnx_model.ByteSize() < onnx.checker.MAXIMUM_PROTOBUF: | |||
There was a problem hiding this comment.
Good idea with this check. But checking >2Gb models is supported after they had been saved:
The crux is, you should call the checker:
- not on the variable that holds a model in the memory
- ...but on the path (string) to the model on disk (assuming that the external data file is in the same folder side-by-side with the model)
I will approve this PR, but planning to audit the onnx pathways later and see whether we can easily account for the large models as well.
There was a problem hiding this comment.
Wait, actually this pathway theoretically should work for both small and large onnx files - validate_path takes a path to the model as the input, this, in theory, should not fail...
rahul-tuli
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets ONNX export around the issue of checking models that are too large for
check_model(). There are still probably issues with saving ONNX models that are too large