[ONNX] support for setting/getting string onnx tensor shapes #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
reviewed
Mar 24, 2023
rahul-tuli
requested changes
Mar 24, 2023
bfineran
commented
Mar 24, 2023
rahul-tuli
approved these changes
Mar 24, 2023
dbogunowicz
approved these changes
Mar 24, 2023
bfineran
added a commit
that referenced
this pull request
Mar 24, 2023
* [ONNX] support for setting/getting string onnx tensor shapes * Apply suggestions from code review
bfineran
added a commit
that referenced
this pull request
Mar 24, 2023
* [ONNX] support for setting/getting string onnx tensor shapes * Apply suggestions from code review
bfineran
added a commit
that referenced
this pull request
Mar 24, 2023
bfineran
added a commit
that referenced
this pull request
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple fix to support setting str tensor shapes to the
dim_paramone of attribute of dim in tensor shape.supports a YOLOv5 patch