Add log printout to announce modifier logging #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSGulin
requested review from
mgoin,
eldarkurtic and
mwitiderrick
and removed request for
a team
dbogunowicz
previously approved these changes
Mar 13, 2023
bfineran
previously approved these changes
Mar 13, 2023
rahul-tuli
previously approved these changes
Mar 14, 2023
KSGulin
dismissed stale reviews from rahul-tuli, bfineran, and dbogunowicz
via
5a4f911
KSGulin
force-pushed
the
log_path_announce
branch
from
018e2ec
to
c86fe6b
Compare
bfineran
approved these changes
Mar 16, 2023
mgoin
approved these changes
Mar 16, 2023
KSGulin
added a commit
that referenced
this pull request
Mar 16, 2023
* Add prinout to alert user of modifier logging path * Fix typo * Prevent new files from being created during testing
KSGulin
added a commit
that referenced
this pull request
Mar 16, 2023
* Add prinout to alert user of modifier logging path * Fix typo * Prevent new files from being created during testing
This was referenced Mar 16, 2023
KSGulin
added a commit
that referenced
this pull request
Mar 16, 2023
KSGulin
added a commit
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, modifier logs are saved to the directory
sparse_logsto keep them from cluttering the user's interface while preserving them for debugging purposes. Currently, this is not made known to the user in any way. This PR adds a simple logging message to alert the user of these logs and their save path.Includes as a rider fix to prevent tests from generating persisting files
Test plan
Existing unit tests