[Fix] label_list not being set for NLP token classification training if distillation teacher and student labels do not match (#1414) #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if distillation teacher and student labels do not match (#1414) * [Fix] Fix label_list not being set for NLP token classification training if distillation teacher and student labels do not match * Added two fixes: omitting the labels/indices matching for student/teacher if teacher is a string; prioritizing teacher labels to student labels if teacher labels are string and student's int * revert previous int label patch - allow int labels to let given dataset be the source of truth * only override label_list when teacher and student labels sets are equal --------- Co-authored-by: Damian <damian@neuralmagic.com> Co-authored-by: Benjamin <ben@neuralmagic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fix] Fix label_list not being set for NLP token classification training if distillation teacher and student labels do not match
Added two fixes: omitting the labels/indices matching for student/teacher if teacher is a string; prioritizing teacher labels to student labels if teacher labels are string and student's int
revert previous int label patch - allow int labels to let given dataset be the source of truth
only override label_list when teacher and student labels sets are equal