Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute overall accuracy using number of correct predictions #1341

Merged
merged 5 commits into from
Jan 27, 2023

Conversation

abhinavnmagic
Copy link
Member

No description provided.

@abhinavnmagic abhinavnmagic changed the title Abhinav/test acc fix Compute overall accuracy using number of correct predictions Jan 26, 2023
corey-nm
corey-nm previously approved these changes Jan 26, 2023
Copy link
Contributor

@corey-nm corey-nm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@natuan
Copy link
Contributor

natuan commented Jan 26, 2023

@abhinavnmagic After this is approved, before merging can you also use the fix here to do at least a full training with the model you're working on? I'd like to make sure we won't see anything unexpected.

corey-nm
corey-nm previously approved these changes Jan 26, 2023
@natuan natuan merged commit 4fe3d69 into main Jan 27, 2023
@natuan natuan deleted the abhinav/test_acc_fix branch January 27, 2023 20:47
bfineran pushed a commit that referenced this pull request Feb 2, 2023
* Trying out accuracy fix

* Computing Accuracy using num_correct

* minor fixes

* Moving mutiplication by 100 to accuracy computation, training log fix

* code quality edits
bfineran pushed a commit that referenced this pull request Feb 3, 2023
* Trying out accuracy fix

* Computing Accuracy using num_correct

* minor fixes

* Moving mutiplication by 100 to accuracy computation, training log fix

* code quality edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants