-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute overall accuracy using number of correct predictions #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corey-nm
reviewed
Jan 26, 2023
corey-nm
reviewed
Jan 26, 2023
corey-nm
previously approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 👍
@abhinavnmagic After this is approved, before merging can you also use the fix here to do at least a full training with the model you're working on? I'd like to make sure we won't see anything unexpected. |
a5a8ca7
to
6fecfe6
Compare
corey-nm
previously approved these changes
Jan 26, 2023
natuan
reviewed
Jan 27, 2023
8dade7e
to
2ae697b
Compare
natuan
approved these changes
Jan 27, 2023
anmarques
approved these changes
Jan 27, 2023
bfineran
pushed a commit
that referenced
this pull request
Feb 2, 2023
* Trying out accuracy fix * Computing Accuracy using num_correct * minor fixes * Moving mutiplication by 100 to accuracy computation, training log fix * code quality edits
bfineran
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Trying out accuracy fix * Computing Accuracy using num_correct * minor fixes * Moving mutiplication by 100 to accuracy computation, training log fix * code quality edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.