Update yolov5 integration to accomodate upstream push #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSGulin
requested review from
bfineran,
rahul-tuli and
corey-nm
and removed request for
a team
bfineran
previously approved these changes
Jan 13, 2023
dbogunowicz
previously approved these changes
Jan 17, 2023
…ml into yolov5_upstream_merge
rahul-tuli
previously approved these changes
Jan 18, 2023
bfineran
previously approved these changes
Jan 18, 2023
rahul-tuli
approved these changes
Jan 19, 2023
dbogunowicz
approved these changes
Jan 19, 2023
KSGulin
added a commit
that referenced
this pull request
Jan 24, 2023
bfineran
pushed a commit
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the yolov5 integration files in line with the yolov5 upstream push and fork update as outlined here. There are basically two changes included here:
Removal of data files, configs, and scripts (support files)
As SparseML will now be supported natively in YOLOv5, users will be able to use our tools across both SparseML and the YOLOv5 repos. There is a need to maintain a level of consistency in experience between the two interfaces. Maintaining a copy of the support files within SparseML poses a challenge, as it will be one of three sources for these files which will need to be kept in sync. By removing the files, we're able to track changes to supports files and keep them in sync through straightforward upstream syncs on our YOLOv5 fork.
The support files were originally included in SparseML because at any given time the NM integration of yolov5 was typically a few releases behind the upstream and it was important to expose to the user the exact model architectures, configs, etc. they were using. With the upstream push, our support files will be in sync with the ones on ultralytics/yolov5 and users can reference them there.
Removal of val_onnx
val_onnxwas a script added to neuralmagic/yolov5 for quick DeepSparse base validation of our sparsified models. With the upstream push this functionality is now built into the nominal validation flow.Test Plan
Testing covered in neuralmagic/yolov5#156