Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scikit-learn instead of sklearn #1294

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Use scikit-learn instead of sklearn #1294

merged 1 commit into from
Jan 5, 2023

Conversation

corey-nm
Copy link
Contributor

@corey-nm corey-nm commented Jan 5, 2023

Name of package was changed. Other places in the repo have already been updated

bfineran
bfineran approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like all usages of sklearn are covered in tests. force merging, integration error is due to an updated yolo zoo model

@bfineran bfineran merged commit f8f0ccb into main Jan 5, 2023
@bfineran bfineran deleted the transformers-scikit-learn branch January 5, 2023 18:57
bfineran pushed a commit that referenced this pull request Mar 13, 2023
@corey-nm @bfineran
Use scikit-learn instead of sklearn (#1294)
d00b6d9
bfineran added a commit that referenced this pull request Mar 13, 2023
@bfineran @corey-nm
Use scikit-learn instead of sklearn (#1294) (#1428)
0f8a4a7 
Co-authored-by: corey-nm <109536191+corey-nm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

@rahul-tuli rahul-tuli rahul-tuli approved these changes

@KSGulin KSGulin KSGulin approved these changes

@dbogunowicz dbogunowicz Awaiting requested review from dbogunowicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@corey-nm @bfineran @rahul-tuli @KSGulin