Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for torchvision training flow #1281

Merged
merged 8 commits into from
Jan 5, 2023
Merged

Some fixes for torchvision training flow #1281

merged 8 commits into from
Jan 5, 2023

Conversation

natuan
Copy link
Contributor

@natuan natuan commented Dec 22, 2022

The fixes here are needed to run the training flow w/o an explicit checkpoint, or w/ a checkpoint that has no recipe or optimizer.

Qualification: tested (a) training command from torchvision readme, (b) training (limited) & validating efficientnet_v2-s from zoomodels.

corey-nm
corey-nm previously approved these changes Jan 3, 2023
Copy link
Contributor

@corey-nm corey-nm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes! 🎉

anmarques
anmarques previously approved these changes Jan 3, 2023
Copy link
Member

@anmarques anmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmarques anmarques dismissed stale reviews from corey-nm and themself via 139906a January 4, 2023 21:54
Copy link
Member

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force landing - remaining integration issue is with yolov5 and unrelated to these changes (the recipe update to the integration tests should be unblocking)

@bfineran bfineran merged commit 4051f9e into main Jan 5, 2023
@bfineran bfineran deleted the efficientnet_quant branch January 5, 2023 21:13
corey-nm pushed a commit that referenced this pull request Jan 6, 2023
* Some fixes for torchvision training flow

* Update YOLOv5s model for testing

* Update YOLOv5s model for testing

* Update recipe to make quantization mode general

Co-authored-by: Alexandre Marques <alexandre@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants