Layer-Wise Distillation #1272
Merged
Layer-Wise Distillation #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `teacher_names` -> `teacher_layer_names`
corey-nm
reviewed
Dec 19, 2022
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
corey-nm
reviewed
Dec 19, 2022
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
corey-nm
reviewed
Dec 19, 2022
tests/sparseml/pytorch/sparsification/distillation/test_per_layer_distillation.py
Outdated
Show resolved
Hide resolved
corey-nm
reviewed
Dec 19, 2022
tests/sparseml/pytorch/sparsification/distillation/test_per_layer_distillation.py
Outdated
Show resolved
Hide resolved
corey-nm
reviewed
Dec 19, 2022
tests/sparseml/pytorch/sparsification/distillation/test_per_layer_distillation.py
Show resolved
Hide resolved
corey-nm
reviewed
Dec 19, 2022
tests/sparseml/pytorch/sparsification/distillation/test_per_layer_distillation.py
Show resolved
Hide resolved
corey-nm
reviewed
Dec 19, 2022
tests/sparseml/pytorch/sparsification/distillation/test_per_layer_distillation.py
Show resolved
Hide resolved
corey-nm
reviewed
Dec 19, 2022
tests/sparseml/pytorch/sparsification/distillation/test_per_layer_distillation.py
Outdated
Show resolved
Hide resolved
corey-nm
reviewed
Dec 21, 2022
corey-nm
reviewed
Dec 21, 2022
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
corey-nm
reviewed
Dec 21, 2022
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
KSGulin
reviewed
Dec 25, 2022
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Konstantin Gulin <66528950+KSGulin@users.noreply.github.com>
corey-nm
reviewed
Jan 3, 2023
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
bfineran
suggested changes
Jan 4, 2023
There was a problem hiding this comment.
Looks great @rahul-tuli @corey-nm - few small comments and need to add that small change for serialization then LGTM!
tests/sparseml/pytorch/sparsification/distillation/test_per_layer_distillation.py
Show resolved
Hide resolved
tests/sparseml/pytorch/sparsification/distillation/test_per_layer_distillation.py
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
rahul-tuli
force-pushed
the
layer-wise-distillation
branch
from
006a097
to
96facf9
Compare
bfineran
suggested changes
Jan 9, 2023
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py
Outdated
Show resolved
Hide resolved
* Add to `DISTILL_PARAM_GROUP_KEY` to `__all__`
bfineran
previously approved these changes
Jan 10, 2023
bfineran
approved these changes
Jan 10, 2023
rahul-tuli
added a commit
that referenced
this pull request
Jan 10, 2023
* Initial Commit with Alex's Work * Update `student_names` -> `student_layer_names` Update `teacher_names` -> `teacher_layer_names` * Intermediate commit * Styling * Reorg initialize * More cleanups * Update docstring * Moving finalize logic to update * Tests passing a bit * Fixing lifecycle tests * Changing projection to dict * Cleanup * Adding quantization hooks test * Add failing test for optimizer serialization * Monkey patching optimizer state_dict method * Apply suggestions from code review Co-authored-by: Konstantin Gulin <66528950+KSGulin@users.noreply.github.com> * Update src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py * Adding missing docstrings * Respond to review on modifier/optimizer state_dict * Add a test for modifier load before forward pass * Updating comments * Fix failing test * Add more asserts based on @bfineran 's comments * * Rename `_DISTILL_PARAM_GROUP_KEY` -> `DISTILL_PARAM_GROUP_KEY` * Add to `DISTILL_PARAM_GROUP_KEY` to `__all__` * Move state dict patching to a helper function * Quality Co-authored-by: Corey Lowman <corey@neuralmagic.com> Co-authored-by: corey-nm <109536191+corey-nm@users.noreply.github.com> Co-authored-by: Konstantin Gulin <66528950+KSGulin@users.noreply.github.com>
corey-nm
added a commit
that referenced
this pull request
Jan 11, 2023
* Saving all hooks during quantization block fusing (#1280) * Saving all hooks during quantization block fusing * Clean up delete get block hooks * Layer-Wise Distillation (#1272) * Initial Commit with Alex's Work * Update `student_names` -> `student_layer_names` Update `teacher_names` -> `teacher_layer_names` * Intermediate commit * Styling * Reorg initialize * More cleanups * Update docstring * Moving finalize logic to update * Tests passing a bit * Fixing lifecycle tests * Changing projection to dict * Cleanup * Adding quantization hooks test * Add failing test for optimizer serialization * Monkey patching optimizer state_dict method * Apply suggestions from code review Co-authored-by: Konstantin Gulin <66528950+KSGulin@users.noreply.github.com> * Update src/sparseml/pytorch/sparsification/distillation/modifier_per_layer.py * Adding missing docstrings * Respond to review on modifier/optimizer state_dict * Add a test for modifier load before forward pass * Updating comments * Fix failing test * Add more asserts based on @bfineran 's comments * * Rename `_DISTILL_PARAM_GROUP_KEY` -> `DISTILL_PARAM_GROUP_KEY` * Add to `DISTILL_PARAM_GROUP_KEY` to `__all__` * Move state dict patching to a helper function * Quality Co-authored-by: Corey Lowman <corey@neuralmagic.com> Co-authored-by: corey-nm <109536191+corey-nm@users.noreply.github.com> Co-authored-by: Konstantin Gulin <66528950+KSGulin@users.noreply.github.com> Co-authored-by: corey-nm <109536191+corey-nm@users.noreply.github.com> Co-authored-by: Corey Lowman <corey@neuralmagic.com> Co-authored-by: Konstantin Gulin <66528950+KSGulin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents the main branch for all layer-wise distillation work