Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature branch] openpifpaf integration #1171

Merged
merged 15 commits into from
Dec 1, 2022
Merged

[Feature branch] openpifpaf integration #1171

merged 15 commits into from
Dec 1, 2022

Conversation

corey-nm
Copy link
Contributor

@corey-nm corey-nm commented Nov 18, 2022 •
edited
Loading

Base feature branch

Manual tests:

  1. Ran the training commands listed in the README with yaml file shown in readme and verified sparsity levels changed via log output
  2. Ran the export commands listed in the README with the checkpoint from training command & verified output is runnable with deepsparse.benchmark
  3. Ran the training command with --checkpoint instead of --basenet arg from a non-finished training epoch to verify resume logic
  4. Ran the training command with --checkpoint instead of --basenet from a finished training epoch to verify checkpoint logic

@corey-nm corey-nm marked this pull request as draft November 18, 2022 16:34
dbogunowicz
dbogunowicz reviewed Nov 18, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
dbogunowicz
dbogunowicz previously approved these changes Nov 21, 2022
View reviewed changes
@corey-nm
Basic sparseml integration for openpifpaf (#1176)
1e709f8 
* Basic sparseml integration for openpifpaf

* Updating openpifpaf readme with recipe

* Adding initialize & finalize to openpifpaf

* Review response
corey-nm and others added 4 commits November 22, 2022 16:47
@corey-nm
Moving openpifpaf to src/sparseml
b3036c2
@corey-nm
Adding export script for openpifpaf (#1178)
24dff23 
* Adding export script for openpifpaf

* Updating openpifpaf readme

* Adding --one-shot support to export

* PR responses
@corey-nm
Merge branch 'main' into integration-openpifpaf
d3aee0c
initial commit
79e79a5
corey-nm
corey-nm commented Nov 30, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
Revert "initial commit"
41383a9 
This reverts commit 79e79a5.
corey-nm
corey-nm commented Nov 30, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
corey-nm and others added 5 commits November 30, 2022 14:19
@corey-nm
Revert torch 1.13 changes
f50473d
@corey-nm
Merge branch 'integration-openpifpaf' of https://github.com/neuralmag…
953b125 
…ic/sparseml into integration-openpifpaf
@corey-nm
Revert torch changes in setup
5066152
@dbogunowicz @corey-nm
[Open Pif Paf] User-friendly pathways (#1189)
e7641f2 
* fixing up the bad push

* Apply suggestions from code review

* Update setup.py

Co-authored-by: corey-nm <109536191+corey-nm@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: corey-nm <109536191+corey-nm@users.noreply.github.com>

Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com>
Co-authored-by: corey-nm <109536191+corey-nm@users.noreply.github.com>
@corey-nm
Adding checkpoint manager functionality to openpifpaf (#1188)
5222d9b 
* Adding checkpoint manager functionality to openpifpaf

* Adding ability to load model from zoo stub

* Actually loading state dict from zoo stub

* Pulling basenet from checkpoint

* Styling

* Reworking checkpoint & managers

* Styling

* Fixing bug in load managers

* Fixing checkpoint logic for local file

* Update comment

* Renaming load managers fn
@corey-nm corey-nm marked this pull request as ready for review December 1, 2022 14:25
KSGulin
KSGulin approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@KSGulin KSGulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Love that it fits within sparseml without need for a fork

src/sparseml/openpifpaf/export.py Show resolved Hide resolved
dbogunowicz
dbogunowicz approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@dbogunowicz dbogunowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

bfineran
bfineran approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

@corey-nm corey-nm merged commit e81cd1a into main Dec 1, 2022
@corey-nm corey-nm deleted the integration-openpifpaf branch December 1, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

@KSGulin KSGulin KSGulin approved these changes

@dbogunowicz dbogunowicz dbogunowicz approved these changes

Assignees
No one assigned
Labels
mle-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@corey-nm @bfineran @KSGulin @dbogunowicz