-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] recipe_template cli #1170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing examples work
bfineran
previously approved these changes
Nov 17, 2022
corey-nm
previously approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
easy diff!
rahul-tuli
commented
Nov 18, 2022
corey-nm
approved these changes
Nov 18, 2022
horheynm
approved these changes
Nov 18, 2022
rahul-tuli
added a commit
that referenced
this pull request
Nov 21, 2022
* Fix a small cli bug, update docstring, add test for confirming docstring examples work * Update src/sparseml/pytorch/recipe_template/cli.py
rahul-tuli
added a commit
that referenced
this pull request
Nov 21, 2022
* [Bugfix] recipe_template cli (#1170) * Fix a small cli bug, update docstring, add test for confirming docstring examples work * Update src/sparseml/pytorch/recipe_template/cli.py * Fix a bug where one-shot recipe should be applied in train mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent bug was found in recipe_template where invoking the cli with
sparseml.recipe quantization true --target vnni
would error outthe reason was that from the cli side the mask_type wasn't settable to it defaulted to
unstructured
which is wrong.This PR fixes that by setting the correct mask type from the cli type, and also adds tests to confirm correct working.
before this PR:
after this PR:
The following template can be used to apply this recipe in a
one-shot
manner: