-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe Template extra features #1147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 3499c423b4baecb1529cdb7c49b0b08005cc5534 Author: Rahul Tuli <rahul@neuralmagic.com> Date: Mon Nov 14 12:27:40 2022 -0500 Update the top level callable for recipe template; now the cli utility will reside under `sparseml.recipe_template` entrypoint
* add top level epoch, lr, sparsity overrides to recipe_template - TODO: testing, base for testing added * Add defaults + test * Fix import * Address review comments! Co-authored-by: Benjamin <ben@neuralmagic.com>
* Fill out convenience functions and move them to a top level callable * Also accept bools for pruning
rahul-tuli
requested review from
bfineran,
corey-nm,
dbogunowicz and
KSGulin
and removed request for
bfineran and
corey-nm
November 15, 2022 15:27
rahul-tuli
changed the title
[WIP] Recipe Template extra features
Recipe Template extra features
Nov 15, 2022
corey-nm
previously approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!!
KSGulin
previously approved these changes
Nov 15, 2022
bfineran
approved these changes
Nov 15, 2022
KSGulin
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents the main feature branch for newer additions to
recipe_template
TODOs:
sparseml.pytorch.recipe_template
->sparseml.recipe_template
recipe_template
#1153