Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe Template extra features #1147

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Recipe Template extra features #1147

merged 5 commits into from
Nov 15, 2022

Conversation

rahul-tuli
Copy link
Member

@rahul-tuli rahul-tuli commented Nov 14, 2022

This PR represents the main feature branch for newer additions to recipe_template

TODOs:

commit 3499c423b4baecb1529cdb7c49b0b08005cc5534
Author: Rahul Tuli <rahul@neuralmagic.com>
Date:   Mon Nov 14 12:27:40 2022 -0500

    Update the top level callable for recipe template; now the cli utility will reside under `sparseml.recipe_template` entrypoint
@rahul-tuli rahul-tuli marked this pull request as draft November 14, 2022 18:00
rahul-tuli and others added 2 commits November 15, 2022 09:00
* add top level epoch, lr, sparsity overrides to recipe_template

- TODO: testing, base for testing added

* Add defaults + test

* Fix import

* Address review comments!

Co-authored-by: Benjamin <ben@neuralmagic.com>
* Fill out convenience functions and move them to a top level callable

* Also accept bools for pruning
@rahul-tuli rahul-tuli requested review from bfineran, corey-nm, dbogunowicz and KSGulin and removed request for bfineran and corey-nm November 15, 2022 15:27
@rahul-tuli rahul-tuli marked this pull request as ready for review November 15, 2022 15:28
@rahul-tuli rahul-tuli changed the title [WIP] Recipe Template extra features Recipe Template extra features Nov 15, 2022
corey-nm
corey-nm previously approved these changes Nov 15, 2022
Copy link
Contributor

@corey-nm corey-nm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

KSGulin
KSGulin previously approved these changes Nov 15, 2022
@KSGulin
Copy link
Contributor

KSGulin commented Nov 15, 2022

@rahul-tuli rahul-tuli dismissed stale reviews from KSGulin and corey-nm via 5f884e9 November 15, 2022 15:59
Copy link
Contributor

@KSGulin KSGulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahul-tuli rahul-tuli merged commit 3c46e3d into main Nov 15, 2022
@rahul-tuli rahul-tuli deleted the recipe_template branch November 15, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants