-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YOLOV8] Add--datasets-dir
to yolov8 entrypoints
#997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogunowicz
changed the title
[YOLOV8] Adding
[YOLOV8] AddApr 12, 2023
--datasets-dir
to yolov8 entrypoints--datasets-dir
to yolov8 entrypoints
dbogunowicz
force-pushed
the
feature/damian/support_dataset_yaml
branch
from
April 13, 2023 15:43
2a86886
to
5bcd38c
Compare
dbogunowicz
commented
Apr 13, 2023
bfineran
previously approved these changes
Apr 13, 2023
KSGulin
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Clean implementation and well documented
rahul-tuli
approved these changes
Apr 20, 2023
mgoin
pushed a commit
that referenced
this pull request
Apr 25, 2023
* finished * Update src/deepsparse/yolov8/validation.py * address PR comments * PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing changes from sparseml to deepsparse as well: neuralmagic/sparseml#1520
Testing:
tested the validation pathways with/without the argument. Performing as expected.