Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YOLOV8] Add--datasets-dir to yolov8 entrypoints #997

Merged
merged 6 commits into from
Apr 20, 2023

Conversation

dbogunowicz
Copy link
Contributor

@dbogunowicz dbogunowicz commented Apr 12, 2023

Introducing changes from sparseml to deepsparse as well: neuralmagic/sparseml#1520

Testing:
tested the validation pathways with/without the argument. Performing as expected.

@dbogunowicz dbogunowicz changed the title [YOLOV8] Adding --datasets-dir to yolov8 entrypoints [YOLOV8] Add--datasets-dir to yolov8 entrypoints Apr 12, 2023
@dbogunowicz dbogunowicz force-pushed the feature/damian/support_dataset_yaml branch from 2a86886 to 5bcd38c Compare April 13, 2023 15:43
@dbogunowicz dbogunowicz marked this pull request as ready for review April 13, 2023 15:45
bfineran
bfineran previously approved these changes Apr 13, 2023
Copy link
Contributor

@KSGulin KSGulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Clean implementation and well documented

@dbogunowicz dbogunowicz merged commit 9dbe9b4 into main Apr 20, 2023
@dbogunowicz dbogunowicz deleted the feature/damian/support_dataset_yaml branch April 20, 2023 11:49
mgoin pushed a commit that referenced this pull request Apr 25, 2023
* finished

* Update src/deepsparse/yolov8/validation.py

* address PR comments

* PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants