Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #931

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Update README.md #931

merged 4 commits into from
Jun 1, 2023

Conversation

Beth-Kosis
Copy link
Contributor

Line 6: Is this a heading? a link?
Line 77: Is there info to be added for the Expected Output?
Lines 103 and 131: Should CIF and CAF be PIF and PAF for consistency?
Line 105: Can we eliminate the word "probably" because it implies ambiguity?

Line 6:  Is this a heading? a link?
Line 77:  Is there info to be added for the Expected Output?
Lines 103 and 131:  Should CIF and CAF be PIF and PAF for consistency?
Line 105:  Can we eliminate the word "probably" because it implies ambiguity?
@dbogunowicz
Copy link
Contributor

dbogunowicz commented Mar 2, 2023

Oh wow, I am a bit embarrassed.
this README was initially my brain dump to communicate some of the important things I found out about openpifpaf. Then I managed to beautify it to some degree, but I am suspicious about whether this is overall in a good state. I would personally redo it so that it looks more like our IC or transformers READMEs.

@jeanniefinks
Copy link
Member

@dbogunowicz may you reply with the URLs to the IC or transformers READMEs in question so we're looking at the ones you are citing, thanks!

@mgoin mgoin merged commit 3ac2c70 into main Jun 1, 2023
4 of 7 checks passed
@mgoin mgoin deleted the BKosis-OpenPifPaf-Inference-Pipelines branch June 1, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants