Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[transformers] do not ignore any labels in conll eval pipeline #903

Merged
merged 1 commit into from
Feb 6, 2023
Merged

[transformers] do not ignore any labels in conll eval pipeline #903

merged 1 commit into from
Feb 6, 2023

Conversation

bfineran
Copy link
Contributor

@bfineran bfineran commented Feb 6, 2023

fixes a bug where outputs ignored by the default ignore_labels value would cause a size mismatch with the expected labels length during metrics computation

test_plan:
verified manually. research team to QA

@bfineran bfineran self-assigned this Feb 6, 2023
dbogunowicz
dbogunowicz approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@dbogunowicz dbogunowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So by default zeros were being omitted and this caused the issue?

@bfineran bfineran merged commit 9e5202e into main Feb 6, 2023
@bfineran bfineran deleted the transformers-eval-conll-patch branch February 6, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSGulin KSGulin KSGulin approved these changes

@dbogunowicz dbogunowicz dbogunowicz approved these changes

@anmarques anmarques Awaiting requested review from anmarques

Assignees

@bfineran bfineran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bfineran @KSGulin @dbogunowicz