[Fix] QA Pipeline fails on SQuAD with seq_len=128 #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corey-nm
approved these changes
Jan 27, 2023
KSGulin
approved these changes
Jan 27, 2023
bfineran
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the: https://app.asana.com/0/1201735099598270/1203822912826533/f
This PR addresses an issue where the default value for the
doc_strideargument was set too high.According to the documentation for the transformers library, the value of
doc_strideshould be smaller than the difference betweenmax_seq_lengthand the sum of the length of the truncated question and the number of special tokens (sequence_added_tokens).doc_stride < max_seq_length - len(truncated_question) - sequence_added_tokensSpecifically, for a
max_seq_lengthof128, assuming not special tokens, thedoc_strideshould be less than the length of the question string. This PR reduces the value ofdoc_strideto align with this guideline.