Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System Logging] Feature Branch #821

Merged
merged 16 commits into from
Jan 5, 2023

Conversation

dbogunowicz
Copy link
Contributor

@dbogunowicz dbogunowicz commented Dec 19, 2022

The Main Feature Branch for the System Logging Functionality

Major highlights

Support for three types of System Logging Groups

The user now has the ability to enable/disable system logging functionality. This PR introduces three system logging groups (each of them can be turned on/off at will):

  • request_details group - logs information pertaining to the request sent to the server
  • resource_utilization group - logs information pertaining to the amountof resources being utilized by the server
  • prediction_latency group - logs information pertaining to the latency of different stages of the pipeline (this information was being logged before this commit, but now it has been refactored and included as a system logging group)

User interface that enables changing the system logging settings

We can now pass the extended ServerConfig.

system_logging:
      enable: True # enables/disables system logging globally
      resource_utilization:
          enable: True # enables/disables system logging on the group level
          target_loggers: ["python"] # allows the user to specify the particular set of loggers to handle the relevant logs
     prediction_latency:
          enable: False 
endpoints:
      route: /unpruned/predict
      model: zoo:nlp/question_answering/bert-base/pytorch/huggingface/squad/base-none

That will enable data and/or system logging and enable the user to have granular control over the logging functionality.

Other notable changes:

  • refactored the identifier structure and the matching logic in the FunctionLogger ( between the target identifier and the incoming identifier)
  • added the infrastructure that hopefully further enables seamless scaling of the system logging functionality. Either in terms of the number of items that are to be logged within the existing system logging groups or in terms of increasing the set of system logging groups available.
  • added unit- and E2E- tests for new functionalities.

bogunowicz@arrival.com and others added 15 commits December 19, 2022 17:53
* initial commit

* fix unittest

* Update tests/server/test_build_logger.py

* ready for review

* Apply suggestions from code review

* fix tests

* answer PR comments

* update defaults in config

* [System Logging] Clean up identifier design (#826)

* initial commit

* updates

* Delete empty

* initial commit

* finish docstrings

* Update src/deepsparse/loggers/helpers.py

Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com>

* Delete PROPOSAL.md

* update _all_

* changes after PR comments

Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com>
* initial commit

* fix unittest

* Update tests/server/test_build_logger.py

* ready for review

* Apply suggestions from code review

* fix tests

* answer PR comments

* initial commit

* update defaults in config

* add kwargs to resource utilization

* fix test

* [System Logging] Clean up identifier design (#826)

* initial commit

* updates

* Delete empty

* initial commit

* finish docstrings

* Update src/deepsparse/loggers/helpers.py

Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com>

* Delete PROPOSAL.md

* update _all_

* Update src/deepsparse/server/system_logging.py

Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>

* addressing PR comments

* fix typo in pipeline

* ready for re-review

* style

* [System Logging] Log request details (#831)

* initial commit

* done

* quality

* address PR comments

* ready for re-review"
"

* now ready

Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com>

* enable system logging through server config

* ready for review

* [System Logging] Few fixes post testing (#841)

Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com>

Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com>
Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
Copy link
Contributor

@corey-nm corey-nm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 nice work!!!

@dbogunowicz dbogunowicz merged commit 2c6d6b1 into main Jan 5, 2023
@dbogunowicz dbogunowicz deleted the feature/damian/logging14_feature_branch branch January 5, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants