-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[System Logging] Feature Branch #821
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit * fix unittest * Update tests/server/test_build_logger.py * ready for review * Apply suggestions from code review * fix tests * answer PR comments * update defaults in config * [System Logging] Clean up identifier design (#826) * initial commit * updates * Delete empty * initial commit * finish docstrings * Update src/deepsparse/loggers/helpers.py Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> * Delete PROPOSAL.md * update _all_ * changes after PR comments Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com>
* initial commit * fix unittest * Update tests/server/test_build_logger.py * ready for review * Apply suggestions from code review * fix tests * answer PR comments * initial commit * update defaults in config * add kwargs to resource utilization * fix test * [System Logging] Clean up identifier design (#826) * initial commit * updates * Delete empty * initial commit * finish docstrings * Update src/deepsparse/loggers/helpers.py Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> * Delete PROPOSAL.md * update _all_ * Update src/deepsparse/server/system_logging.py Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * addressing PR comments * fix typo in pipeline * ready for re-review * style * [System Logging] Log request details (#831) * initial commit * done * quality * address PR comments * ready for re-review" " * now ready Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> * enable system logging through server config * ready for review * [System Logging] Few fixes post testing (#841) Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
…hub.com/neuralmagic/deepsparse into feature/damian/logging14_feature_branch
…hub.com/neuralmagic/deepsparse into feature/damian/logging14_feature_branch
bfineran
approved these changes
Jan 4, 2023
corey-nm
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 nice work!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Main Feature Branch for the System Logging Functionality
Major highlights
Support for three types of System Logging Groups
The user now has the ability to enable/disable system logging functionality. This PR introduces three system logging groups (each of them can be turned on/off at will):
request_details
group - logs information pertaining to the request sent to the serverresource_utilization
group - logs information pertaining to the amountof resources being utilized by the serverprediction_latency
group - logs information pertaining to the latency of different stages of the pipeline (this information was being logged before this commit, but now it has been refactored and included as a system logging group)User interface that enables changing the system logging settings
We can now pass the extended
ServerConfig
.That will enable data and/or system logging and enable the user to have granular control over the logging functionality.
Other notable changes:
FunctionLogger
( between the target identifier and the incoming identifier)