Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Logging] Target identifier bug fix / Making PrometheusLogger more robust #791

Merged
merged 3 commits into from
Nov 22, 2022
Merged

[Data Logging] Target identifier bug fix / Making PrometheusLogger more robust #791

merged 3 commits into from
Nov 22, 2022

Conversation

dbogunowicz
Copy link
Contributor

No description provided.

@dbogunowicz dbogunowicz requested review from bfineran and corey-nm and removed request for bfineran November 22, 2022 09:11
corey-nm
corey-nm previously approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@corey-nm corey-nm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice improvements

@dbogunowicz dbogunowicz merged commit b48829c into main Nov 22, 2022
@dbogunowicz dbogunowicz deleted the fix/damian/data_logging branch November 22, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

@corey-nm corey-nm corey-nm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbogunowicz @bfineran @corey-nm