Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme based on feedback and review for deepsparse enterprise #723

Merged
merged 7 commits into from
Oct 27, 2022

Conversation

markurtz
Copy link
Member

No description provided.

@markurtz markurtz self-assigned this Oct 26, 2022
README.md Show resolved Hide resolved
mgoin
mgoin previously approved these changes Oct 27, 2022
Copy link
Member

@jeanniefinks jeanniefinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be a separate PR (?) but noting here:

Under ### License, this content should be updated TO:

The Community Edition of the project's binary containing the DeepSparse Engine is licensed under the Neural Magic Engine License. Example files and scripts included in this repository are licensed under the Apache License Version 2.0 as noted.

The Enterprise Edition requires a Trial License or can be fully licensed for production, commercial applications.

rgreenberg1
rgreenberg1 previously approved these changes Oct 27, 2022
Copy link
Contributor

@rgreenberg1 rgreenberg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Jeannie's change, otherwise LGTM.

@markurtz markurtz dismissed stale reviews from rgreenberg1 and mgoin via 1ccf8ea October 27, 2022 13:03
@markurtz
Copy link
Member Author

@jeanniefinks updated for your comment

@robertgshaw2-neuralmagic
Copy link
Contributor

This looks good to me

Copy link
Contributor

@rgreenberg1 rgreenberg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markurtz markurtz merged commit 04cfdfb into main Oct 27, 2022
@markurtz markurtz deleted the enterprise-license-readme-updates branch October 27, 2022 13:49
rahul-tuli pushed a commit that referenced this pull request Oct 27, 2022
…723)

* Update readme based on feedback and review for deepsparse enterprise

* fixes from discussion on deepsparse vs deepsparse-ent and where those docs will live. New destination is the docs.neuralmagic.com website

* add proper css and html for readme headers and chips

* update links in readme to deepsparse-ent for docs

* update license messaging

* update license messaging
rahul-tuli pushed a commit that referenced this pull request Oct 27, 2022
…723)

* Update readme based on feedback and review for deepsparse enterprise

* fixes from discussion on deepsparse vs deepsparse-ent and where those docs will live. New destination is the docs.neuralmagic.com website

* add proper css and html for readme headers and chips

* update links in readme to deepsparse-ent for docs

* update license messaging

* update license messaging
bfineran pushed a commit that referenced this pull request Oct 27, 2022
…723) (#726)

* Update readme based on feedback and review for deepsparse enterprise

* fixes from discussion on deepsparse vs deepsparse-ent and where those docs will live. New destination is the docs.neuralmagic.com website

* add proper css and html for readme headers and chips

* update links in readme to deepsparse-ent for docs

* update license messaging

* update license messaging

Co-authored-by: Mark Kurtz <mark.kurtz@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants