Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils/artifacts.py to MANIFEST #495

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Add utils/artifacts.py to MANIFEST #495

merged 1 commit into from
Jul 5, 2022

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Jul 5, 2022

The functions needed for the artifact store functionality to work in setup.py aren't included by default in the source distribution

https://packaging.python.org/en/latest/guides/using-manifest-in/

The functions needed for the artifact store functionality to work in setup.py aren't included by default in the source distribution

https://packaging.python.org/en/latest/guides/using-manifest-in/
Copy link
Member

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending confirmation of fix

@mgoin
Copy link
Member Author

mgoin commented Jul 5, 2022

Tested on internal pypi and got the proper error for my macbook

OSError: Native Mac is currently unsupported for the DeepSparse Engine. Please run on a Linux system or within a Linux container on Mac. More info can be found in our docs here: https://docs.neuralmagic.com/deepsparse/source/hardware.html

@mgoin mgoin merged commit 0198144 into main Jul 5, 2022
@mgoin mgoin deleted the artifacts-manifest branch July 5, 2022 21:31
mgoin added a commit that referenced this pull request Jul 5, 2022
The functions needed for the artifact store functionality to work in setup.py aren't included by default in the source distribution

https://packaging.python.org/en/latest/guides/using-manifest-in/
mgoin added a commit that referenced this pull request Jul 6, 2022
The functions needed for the artifact store functionality to work in setup.py aren't included by default in the source distribution

https://packaging.python.org/en/latest/guides/using-manifest-in/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants