Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix import bug with numpy_log_softmax #1563

Merged
merged 1 commit into from
Jan 25, 2024
Merged

[Bug] Fix import bug with numpy_log_softmax #1563

merged 1 commit into from
Jan 25, 2024

Conversation

rahul-tuli
Copy link
Member

This PR fixes a bug with the recently added numpy_log_softmax function,
which was causing import errors

Before this PR:

In [1]: from deepsparse.utils import numpy_log_softmax                                                                            
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-056db553cbcd> in <module>
----> 1 from deepsparse.utils import numpy_log_softmax

ImportError: cannot import name 'numpy_log_softmax' from 'deepsparse.utils' (/home/rahul/projects/deepsparse/src/deepsparse/utils/__init__.py)

After this PR:

In [1]: from deepsparse.utils import numpy_log_softmax                                                                               

In [2]:

@rahul-tuli rahul-tuli self-assigned this Jan 25, 2024
@rahul-tuli rahul-tuli added the bug Something isn't working label Jan 25, 2024
@mgoin mgoin merged commit 3637800 into main Jan 25, 2024
13 checks passed
@mgoin mgoin deleted the add-numpy-log-softmax-to-all branch January 25, 2024 15:58
rahul-tuli added a commit that referenced this pull request Feb 13, 2024
@rahul-tuli
Fix import bug with numpy_log_softmax (#1563)
c0891f2
@rahul-tuli rahul-tuli mentioned this pull request Feb 13, 2024
Merged
bfineran added a commit that referenced this pull request Feb 13, 2024
@bfineran
[cherry-pick] [Bug] Fix import bug with numpy_log_softmax (#1563) #1603
abf89a5
rahul-tuli added a commit that referenced this pull request Feb 13, 2024
@rahul-tuli
Fix import bug with numpy_log_softmax (#1563) (#1602)
993b345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@bfineran bfineran bfineran approved these changes

@dsikka dsikka dsikka approved these changes

@dbogunowicz dbogunowicz dbogunowicz approved these changes

@Satrat Satrat Awaiting requested review from Satrat

@horheynm horheynm Awaiting requested review from horheynm

Assignees

@rahul-tuli rahul-tuli

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rahul-tuli @mgoin @bfineran @dsikka @dbogunowicz