[Fix] Remove erronous LIB.kv_cache input when using external kv cache management #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
approved these changes
Oct 20, 2023
dbogunowicz
added a commit
that referenced
this pull request
Nov 13, 2023
… management (#1337) * initial commit * initial commit * cleanup * cleanup2
bfineran
pushed a commit
that referenced
this pull request
Nov 29, 2023
… for Llama2, Mistral models (#1439) * [Fix] Remove erronous LIB.kv_cache input when using external kv cache management (#1337) * initial commit * initial commit * cleanup * cleanup2 * initial commit * initial commit cleanup more cleaning up specify the tokenizer types PR comments responds add tests rename variable to be more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be passing the
kv_cacheinput to the engine when running with external kv cache management - the kv cache values are already included in theinput