Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deepsparse.benchmark] enable benchmarking internal kv cache #1308

Merged
merged 2 commits into from
Oct 11, 2023
Merged

[deepsparse.benchmark] enable benchmarking internal kv cache #1308

merged 2 commits into from
Oct 11, 2023

Conversation

bfineran
Copy link
Member

No description provided.

@bfineran bfineran requested a review from mgoin October 10, 2023 20:40
@mgoin mgoin changed the title [deepsparse.bechmark] enable benchmarking internal kv cache [deepsparse.benchmark] enable benchmarking internal kv cache Oct 10, 2023
@mgoin mgoin marked this pull request as ready for review October 10, 2023 21:54
mgoin
mgoin approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, tested by me on some sparse quantized models to match up with debug_analysis with internal kv cache - and drops performance without it enabled

@mgoin mgoin merged commit 428d4b5 into main Oct 11, 2023
13 checks passed
@mgoin mgoin deleted the benchmark-internal-cache branch October 11, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bfineran @mgoin