Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] model_to_path should also download .data files from zoo #1296

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

bfineran
Copy link
Member

@bfineran bfineran commented Oct 3, 2023

fixes issue in #1247 where only model.onnx would be downloaded by default in model_to_path from a deployment directory. this breaks flows such as benchmark and compile_model which rely on only the model_to_path for the onnx file path from zoo. with this change the function now also searches for and downloads .data* files

test_plan:
verified locally that data file downloads now trigger with a stub such as zoo:mpt-7b-dolly_mpt_pretrain-base where they weren't before

@bfineran bfineran self-assigned this Oct 3, 2023
Copy link
Member

@horheynm horheynm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was for
failed:Invalid fd was supplied: -1?

@bfineran bfineran merged commit 09ad1d9 into main Oct 4, 2023
12 of 13 checks passed
@bfineran bfineran deleted the download-onnx-zoo-data-files branch October 4, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants